drm/amdkfd: Avoid integer underflow with ffs in EOP ring size calc

Browse source

The low 6 bits of cp_hqd_eop_control store the base-2 logarithm
of the EOP ring size. This was calculated as

ffs(q->eop_ring_buffer_size / sizeof(unsigned int)) - 1 - 1

But ffs can in theory return 1 or 0, so this could underflow
(although in practice the ring buffer size cannot be less than 4096).

Change this to

ffs(q->eop_ring_buffer_size / sizeof(unsigned int) / 4)

using properties of logarithms.

Reviewed-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: David Francis <David.Francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

David Francis 2026-08-05 09:51:35 -04:00 • committed by Alex Deucher

parent 7ea6a47224

commit 4f18c56630

4 changed files with 4 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c

View file

2

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c

View file

2

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v12.c

View file

2

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v12_1.c

View file