mlx4: Correct error flows in rereg_mr

Browse source

This patch addresses feedback from Sagi Grimberg on the rereg_mr
implementation of mlx4.  The following are fixed:

1. Set the correct pd_flags
2. Make sure we change the iova and size MR fields only after
   successful write and allocation of the MTTs.
3. Make the error checking more robust

Fixes: e630664c83 ("mlx4_core: Add helper functions to support MR re-registration")
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

...

This commit is contained in:

Matan Barak 2014-09-11 13:18:37 +03:00 • committed by Roland Dreier

parent 50e2ec9105

commit 4ff0acca73

2 changed files with 27 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/infiniband/hw/mlx4/mr.c

View file

33

drivers/net/ethernet/mellanox/mlx4/mr.c

View file