Merge branch 'libbpf: uprobe name-based attach followups'

Browse source

Alan Maguire says:

====================

Follow-up series to [1] to address some suggestions from Andrii to
improve parsing and make it more robust (patches 1, 2) and to improve
validation of u[ret]probe firing by validating expected argument
and return values (patch 3).

[1] https://lore.kernel.org/bpf/164903521182.13106.12656654142629368774.git-patchwork-notify@kernel.org/

Changes since v1:
- split library name, auto-attach parsing into separate patches (Andrii, patches 1, 2)
- made str_has_sfx() static inline, avoided repeated strlen()s by storing lengths,
  used strlen() instead of strnlen() (Andrii, patch 1)
- fixed sscanf() arg to use %li, switched logging to use "prog '%s'" format,
  used direct strcmp() on probe_type instead of prefix check (Andrii, patch 2)
- switched auto-attach tests to log parameter/return values to be checked by
  user-space side of tests. Needed to add pid filtering to avoid capturing
  stray malloc()s (Andrii, patch 3)
====================

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

...

This commit is contained in:

Andrii Nakryiko 2022-04-07 11:42:51 -07:00

parent 9fc4476a08 1717e24801

commit 502b0e3dcb

4 changed files with 95 additions and 67 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

83

tools/lib/bpf/libbpf.c

View file

11

tools/lib/bpf/libbpf_internal.h

View file

25

tools/testing/selftests/bpf/prog_tests/uprobe_autoattach.c

View file

43

tools/testing/selftests/bpf/progs/test_uprobe_autoattach.c

View file