drm/i915: Only close vma we open

Browse source

The history of i915_vma_close() is confusing, as is its use. As the
lifetime of the i915_vma is currently bounded by the object it is
attached to, we needed a means of identify when a vma was no longer in
use by userspace (via the user's fd). This is further complicated by
that only ppgtt vma should be closed at the user's behest, as the ggtt
were always shared.

Now that we attach the vma to a lut on the user's context, the open
count does indicate how many unique and open context/vm are referencing
this vma from the user. As such, we can and should just use the
open_count to track when the vma is still in use by userspace.

It's a poor man's replacement for reference counting.

Closes: https://gitlab.freedesktop.org/drm/intel/issues/1193
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200422190558.30509-1-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2020-04-22 20:05:58 +01:00

parent b4892e4404

commit 50689771c8

9 changed files with 56 additions and 107 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/gpu/drm/i915/gem/i915_gem_context.c

View file

2

drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

View file

4

drivers/gpu/drm/i915/gem/i915_gem_object.c

View file

83

drivers/gpu/drm/i915/gem/selftests/huge_pages.c

View file

1

drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c

View file

4

drivers/gpu/drm/i915/gt/intel_renderstate.c

View file

5

drivers/gpu/drm/i915/gvt/scheduler.c

View file

28

drivers/gpu/drm/i915/i915_vma.c

View file

32

drivers/gpu/drm/i915/selftests/i915_gem_gtt.c

View file