net: hns3: Change return type of hnae3_register_ae_dev

Browse source

If hclge.ko has not been inserted, the value of ret always is zero
in hnae3_register_ae_dev. If hclge.ko has been inserted, the value
of ret is zero or non zero. Different execution ways have different
results. It is confusing.

The ae_dev which is initialized failed can be reinitialized when we
remove hclge.ko and insert it again. For the case initializing client
instance, it is just like the case initializing ae_dev. The main function
of hnae3_register_ae_dev is adding the ae_dev to ad_dev list. Because
adding ae_dev is always ok, we does not need to return any in this
function.

This patch changes the return type of hnae3_register_ae_dev from int
to void.

Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Fuyun Liang 2018-05-15 19:20:08 +01:00 • committed by David S. Miller

parent e3afa96365

commit 50fbc237b7

3 changed files with 3 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/ethernet/hisilicon/hns3/hnae3.c

View file

2

drivers/net/ethernet/hisilicon/hns3/hnae3.h

View file

4

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

View file