net/mlx5e: Avoid accessing NULL pointer at ndo_select_queue

Browse source

To avoid multiply/division operations on the data path,
we hold a {channel, tc}==>txq mapping table.
We held this mapping table inside the channel object that is
being destroyed upon some configuration operations (e.g MTU change).
So in case ndo_select_queue occurs during such a configuration operation,
it may access a NULL channel pointer, resulting in kernel panic.
To fix this issue we moved the {channel, tc}==>txq mapping table
outside the channel object so that it will be available also
during such configuration operations.

Signed-off-by: Rana Shahout <ranas@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Rana Shahout 2015-08-23 16:12:14 +03:00 • committed by David S. Miller

parent 94c10f0ea3

commit 5283af899a

3 changed files with 6 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/mellanox/mlx5/core/en.h

View file

8

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

View file

2

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

View file