nfsd: let nfsd_symlink assume null-terminated data

Browse source

Currently nfsd_symlink has a weird hack to serve callers who don't
null-terminate symlink data: it looks ahead at the next byte to see if
it's zero, and copies it to a new buffer to null-terminate if not.

That means callers don't have to null-terminate, but they *do* have to
ensure that the byte following the end of the data is theirs to read.

That's a bit subtle, and the NFSv4 code actually got this wrong.

So let's just throw out that code and let callers pass null-terminated
strings; we've already fixed them to do that.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

J. Bruce Fields 2014-06-20 11:52:21 -04:00

parent 0aeae33f5d

commit 52ee04330f

5 changed files with 7 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/nfsd/nfs3proc.c

View file

2

fs/nfsd/nfs4proc.c

View file

2

fs/nfsd/nfsproc.c

View file

17

fs/nfsd/vfs.c

View file

2

fs/nfsd/vfs.h

View file