spi: fsl-dspi: fix use-after-free in remove path

Browse source

spi_unregister_controller() not only unregisters the controller, but
also frees the controller. This will free the driver data with it, so
we must not access it later dspi_remove().

Solve this by allocating the driver data separately from the SPI
controller.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://lore.kernel.org/r/20200923131026.20707-1-s.hauer@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Sascha Hauer 2020-09-23 15:10:26 +02:00 • committed by Mark Brown

parent b867eef4cf

commit 530b5affc6

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 7 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

12

drivers/spi/spi-fsl-dspi.c

View file