[PATCH] mac80211: fix iff_promiscs, iff_allmultis race

Browse source

When we update the counters iff_promiscs and iff_allmultis
in struct ieee80211_local we have no common lock held to
protect them. The problem is that the update to each counter
may not be atomic, so we could end up with iff_promiscs == -1
in unfortunate conditions. To fix it, use atomic_t values.
It doesn't matter whether the two counters are updated
together atomically or not, if there are two invocations
of set_multicast_list we will end up with multiple
configure_filter() invocations of which the latter will always
be correct.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Johannes Berg 2007-09-26 15:19:47 +02:00 • committed by David S. Miller

parent 50741ae05a

commit 53918994b7

3 changed files with 10 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

12

net/mac80211/ieee80211.c

View file

5

net/mac80211/ieee80211_i.h

View file

3

net/mac80211/rx.c

View file