nvme: fix refcounting imbalance when all paths are down

Browse source

When the last path to a ns_head drops the current code
removes the ns_head from the subsystem list, but will only
delete the disk itself if the last reference to the ns_head
drops. This is causing an refcounting imbalance eg when
applications have a reference to the disk, as then they'll
never get notified that the disk is in fact dead.
This patch moves the call 'del_gendisk' into nvme_mpath_check_last_path(),
ensuring that the disk can be properly removed and applications get the
appropriate notifications.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Hannes Reinecke 2021-07-16 13:30:35 +02:00 • committed by Christoph Hellwig

parent 7764656b10

commit 5396fdac56

3 changed files with 21 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

drivers/nvme/host/core.c

View file

9

drivers/nvme/host/multipath.c

View file

11

drivers/nvme/host/nvme.h

View file