fm10k: fix possible null pointer deref after kcalloc

Browse source

When writing a new default redirection table, we needed to populate
a new RSS table using ethtool_rxfh_indir_default. We populated this
table into a region of memory allocated using kcalloc, but never checked
this for NULL. Fix this by moving the default table generation into
fm10k_write_reta. If this function is passed a table, use it. Otherwise,
generate the default table using ethtool_rxfh_indir_default, 4 at at
time.

Fixes: 0ea7fae440 ("fm10k: use ethtool_rxfh_indir_default for default redirection table")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

...

This commit is contained in:

Jacob Keller 2016-04-07 08:21:20 -07:00 • committed by Jeff Kirsher

parent 11ec36a974

commit 540a5d8590

2 changed files with 22 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

26

drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c

View file

14

drivers/net/ethernet/intel/fm10k/fm10k_main.c

View file