staging: comedi: addi_apci_3501: introduce apci3501_wait_for_dac()

Browse source

Refactor the code that waits for the DAC to be ready into a helper
function.

A timeout of some sort should be added to this helper so code the
users to expect the error condition. In i_APCI3501_WriteAnalogOutput()
just return the error and don't actually write the new value to the
DAC. In apci3501_reset() output a dev_warn() that the DAC was not
ready.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

H Hartley Sweeten 2013-01-23 12:44:40 -07:00 • committed by Greg Kroah-Hartman

parent 99c9fa48b6

commit 5458f3e7b5

2 changed files with 27 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c

View file

29

drivers/staging/comedi/drivers/addi_apci_3501.c

View file