platform/x86/intel/ifs: Reorganize driver data

Browse source

The struct holding device driver data contained both read only(ro)
and read write(rw) fields.

Separating ro fields from rw fields was recommended as
a preferable design pattern during review[1].

Group ro fields into a separate const struct. Associate it to
the miscdevice being registered by keeping its pointer in the
same container struct as the miscdevice.

Link: https://lore.kernel.org/lkml/Y+9H9otxLYPqMkUh@kroah.com/ [1]

Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20230322003359.213046-3-jithu.joseph@intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

...

This commit is contained in:

Jithu Joseph 2023-03-21 17:33:52 -07:00 • committed by Hans de Goede

parent 67f88ffa6d

commit 54c9fcd187

3 changed files with 25 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

12

drivers/platform/x86/intel/ifs/core.c

View file

22

drivers/platform/x86/intel/ifs/ifs.h

View file

3

drivers/platform/x86/intel/ifs/load.c

View file