drm/i915: Unpin vma->obj on early error

Browse source

If we inherit an error along the fence chain, we skip the main work
callback and go straight to the error. In the case of the vma bind
worker, we only dropped the pinned pages from the worker.

In the process, make sure we call the release earlier rather than wait
until the final reference to the fence is dropped (as a reference is
kept while being listened upon).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191216161717.2688274-1-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2019-12-16 16:17:16 +00:00

parent f20c6b278d

commit 54d7195f8c

3 changed files with 27 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

drivers/gpu/drm/i915/gem/i915_gem_clflush.c

View file

15

drivers/gpu/drm/i915/i915_sw_fence_work.c

View file

17

drivers/gpu/drm/i915/i915_vma.c

View file