From 5589ef09f93b85b6f506e279a502d4cf1654f232 Mon Sep 17 00:00:00 2001 From: Maxime Ripard Date: Wed, 16 Sep 2026 10:55:52 +0200 Subject: [PATCH] drm/plane: Remove reset All plane drivers now implement the atomic_create_state hook instead of the reset hook for initial state creation. The reset hook conflated initial state allocation at probe time with hardware and software reset during suspend/resume, making error handling difficult since it is not fallible. Remove the reset hook from struct drm_plane_funcs and the associated call in drm_mode_config_reset(). Reviewed-by: Thomas Zimmermann Link: https://patch.msgid.link/20260916-drm-no-more-plane-reset-v5-9-f590d2003f2c@kernel.org Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_mode_config.c | 4 +--- include/drm/drm_plane.h | 9 --------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c index c7c8e38b192d..48a56f23dadb 100644 --- a/drivers/gpu/drm/drm_mode_config.c +++ b/drivers/gpu/drm/drm_mode_config.c @@ -300,9 +300,7 @@ void drm_mode_config_reset(struct drm_device *dev) drm_colorop_reset(colorop); drm_for_each_plane(plane, dev) { - if (plane->funcs->reset) - plane->funcs->reset(plane); - else if (plane->funcs->atomic_create_state) + if (plane->funcs->atomic_create_state) drm_mode_config_plane_reset_with_create_state(plane); } diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index e757e9dbf132..a16e96aa7e60 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -359,15 +359,6 @@ struct drm_plane_funcs { */ void (*destroy)(struct drm_plane *plane); - /** - * @reset: - * - * Reset plane hardware and software state to off. This function isn't - * called by the core directly, only through drm_mode_config_reset(). - * It's not a helper hook only for historical reasons. - */ - void (*reset)(struct drm_plane *plane); - /** * @set_property: *