drm/i915/display: remove unnecessary PHY_NONE definition

Browse source

PHY_NONE is not really used, but we define it and, thus, need to check
for it in a few places we use phy.  The only potential places where
phy may become PHY_NONE, is in intel_port_to_phy(), where it derives
from port, which can be PORT_NONE.  Many of its callers don't check
for PHY_NONE, which can cause unknown behavior.  Additionally, this
can only happen if the encoder used has PORT_NONE, which should not be
the case either, without unexpected consequences.

Remove the PHY_NONE definition entirely and add a couple of WARNs at
the relevant places, just to be sure.

Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>
Link: https://patch.msgid.link/20260609095525.570614-5-luciano.coelho@intel.com
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

...

This commit is contained in:

Luca Coelho 2026-06-09 12:52:39 +03:00

parent 279b0df165

commit 5655c87693

4 changed files with 11 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/gpu/drm/i915/display/intel_display.c

View file

2

drivers/gpu/drm/i915/display/intel_display.h

View file

6

drivers/gpu/drm/i915/display/intel_display_power_well.c

View file

3

drivers/gpu/drm/i915/display/intel_hti.c

View file