ovl: use is_subdir() for testing if one thing is a subdir of another

Browse source

Rather than using lock_rename(), use the more obvious is_subdir() for
ensuring that neither upper nor workdir contain the other.
Also be explicit in the comment that the two directories cannot be the
same.

As this is a point-it-time sanity check and does not provide any
on-going guarantees, the removal of locking does not introduce any
interesting races.

Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neil@brown.name>
Link: https://patch.msgid.link/20260224222542.3458677-14-neilb@ownmail.net
Signed-off-by: Christian Brauner <brauner@kernel.org>

...

This commit is contained in:

NeilBrown 2026-02-25 09:16:58 +11:00 • committed by Christian Brauner

parent 8348278650

commit 56c8fd738e

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

1 changed files with 5 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

15

fs/overlayfs/super.c

View file