drm/vc4: Convert to atomic_create_state

Browse source

The vc4 crtc implementation provides a custom reset hook. However,
this hook only allocates the state, initializes it with
__drm_atomic_helper_crtc_reset(), sets the assigned_channel field to
VC4_HVS_CHANNEL_DISABLED, and frees the previous state. It does not
perform any hardware reset.

Since this is exactly what the atomic_create_state hook is meant to
do, minus the old state cleanup which the caller handles, convert the
implementation to use atomic_create_state with
__drm_atomic_helper_crtc_state_init() instead.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260821-drm-no-more-crtc-reset-v1-66-fb793475c05a@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>

...

This commit is contained in:

Maxime Ripard 2026-08-21 16:39:42 +02:00

parent 9af077e68d

commit 56f115da1b

No known key found for this signature in database

GPG key ID: 275FCE19A23DBE76

4 changed files with 9 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/gpu/drm/vc4/tests/vc4_mock_crtc.c

View file

14

drivers/gpu/drm/vc4/vc4_crtc.c

View file

2

drivers/gpu/drm/vc4/vc4_drv.h

View file

2

drivers/gpu/drm/vc4/vc4_txp.c

View file