RDMA/cxgb4: Serialize calls to CQ's comp_handler

Browse source

Commit 01e7da6ba5 ("RDMA/cxgb4: Make sure flush CQ entries are
collected on connection close") introduced a potential problem where a
CQ's comp_handler can get called simultaneously from different places
in the iw_cxgb4 driver.  This does not comply with
Documentation/infiniband/core_locking.txt, which states that at a
given point of time, there should be only one callback per CQ should
be active.

This problem was reported by Parav Pandit <Parav.Pandit@Emulex.Com>.
Based on discussion between Parav Pandit and Steve Wise, this patch
fixes the above problem by serializing the calls to a CQ's
comp_handler using a spin_lock.

Reported-by: Parav Pandit <Parav.Pandit@Emulex.Com>
Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

...

This commit is contained in:

Kumar Sanghvi 2011-10-24 21:20:21 +05:30 • committed by Roland Dreier

parent e14d62c05c

commit 581bbe2cd0

4 changed files with 23 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/infiniband/hw/cxgb4/cq.c

View file

10

drivers/infiniband/hw/cxgb4/ev.c

View file

1

drivers/infiniband/hw/cxgb4/iw_cxgb4.h

View file

15

drivers/infiniband/hw/cxgb4/qp.c

View file