x86/resctrl: Initialize on-stack struct rmid_read instances

Browse source

New semantics rely on some struct rmid_read members having NULL values to
distinguish between the SNC and non-SNC scenarios.  resctrl can thus no longer
rely on this struct not being initialized properly.

Initialize all on-stack declarations of struct rmid_read:

  rdtgroup_mondata_show()
  mbm_update()
  mkdir_mondata_subdir()

to ensure that garbage values from the stack are not passed down to other
functions.

  [ bp: Massage commit message. ]

Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Link: https://lore.kernel.org/r/20240628215619.76401-11-tony.luck@intel.com

...

This commit is contained in:

Tony Luck 2024-06-28 14:56:10 -07:00 • committed by Borislav Petkov (AMD)

parent fb1f51f677

commit 587edd7069

3 changed files with 3 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

arch/x86/kernel/cpu/resctrl/ctrlmondata.c

View file

3

arch/x86/kernel/cpu/resctrl/monitor.c

View file

2

arch/x86/kernel/cpu/resctrl/rdtgroup.c

View file