HID: wacom: leds: actually release the LEDs on disconnect

Browse source

There is a bug (?) in devm_led_classdev_register() in which its increments
the refcount of the parent. If the parent is an input device, that means
the ref count never reaches 0 when devm_input_device_release() gets called.
This means that the LEDs and all the devres resources attached to the
input device are not released.

Manually force the release of the group so that the leds are released once
we are done using them.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Ping Cheng <pingc@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

...

This commit is contained in:

Benjamin Tissoires 2016-07-13 18:06:11 +02:00 • committed by Jiri Kosina

parent 97f5541fc0

commit 589e506020

2 changed files with 27 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/hid/wacom.h

View file

27

drivers/hid/wacom_sys.c

View file