IB/IPoIB: Fix bad error flow in ipoib_add_port()

Browse source

Error values of ib_query_port() and ib_query_device() weren't propagated
correctly. Because of that, ipoib_add_port() could return NULL value,
which escaped the IS_ERR() check in ipoib_add_one() and we crashed.

Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

...

This commit is contained in:

Amir Vadai 2015-07-01 14:31:01 +03:00 • committed by Doug Ledford

parent 8a7ff14dcb

commit 58e9cc90cd

1 changed files with 4 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/infiniband/ulp/ipoib/ipoib_main.c

View file