ASoC: codecs: lpass-wsa-macro: handle unexpected input

Browse source

Static analysis reports this problem

lpass-wsa-macro.c:1732:6: warning: Array subscript is undefined
        if (wsa->ec_hq[ec_tx]) {
            ^~~~~~~~~~~~~~~~~

The happens because 'ec_tx' is never initialized and there is
no default in switch statement that sets ec_tx.  Add a default
case that returns an error before the array is accessed.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210430142117.3272772-1-trix@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Tom Rix 2021-04-30 07:21:17 -07:00 • committed by Mark Brown

parent 1d122dd3b1

commit 58f01c7fc8

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 4 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

sound/soc/codecs/lpass-wsa-macro.c

View file