V4L/DVB (6538): em28xx: fix locking to allow accesses from 2 different threads at the same time

Browse source

The attached patch modifies the em28xx driver so that there can be ioctls from
multiple different threads.

This is necessary for capture apps like MPlayer that use different threads for
capturing and channel tuning.

Now the locking is only done for the ioctls that change properties of the
device or access the i2c bus.

It also removes some locks that look unnecessary:

In em28xx_init_dev:
  the videodevice is not registered yet so nothing can access the hardware
 meanwhile, the device struct is not assigned to the interface yet so no race
 with disconnect is possible

In em28xx_release_resources:
  it gets only called when dev->lock is already held

Signed-off-by: Sascha Sommer <saschasommer@freenet.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

...

This commit is contained in:

Sascha Sommer 2007-11-03 21:22:38 -03:00 • committed by Mauro Carvalho Chehab

parent ea4fd5679b

commit 5a80415bca

2 changed files with 80 additions and 73 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

153

drivers/media/video/em28xx/em28xx-video.c

View file

2

drivers/media/video/em28xx/em28xx.h

View file