net/ipv4: Initialize proto and ports in flow struct

Browse source

Updating the FIB tracepoint for the recent change to allow rules using
the protocol and ports exposed a few places where the entries in the flow
struct are not initialized.

For __fib_validate_source add the call to fib4_rules_early_flow_dissect
since it is invoked for the input path. For netfilter, add the memset on
the flow struct to avoid future problems like this. In ip_route_input_slow
need to set the fields if the skb dissection does not happen.

Fixes: bfff486265 ("net: fib_rules: support for match on ip_proto, sport and dport")
Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

David Ahern 2018-05-16 13:36:40 -07:00 • committed by David S. Miller

parent 8ab6ffba14

commit 5a847a6e14

3 changed files with 14 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

net/ipv4/fib_frontend.c

View file

2

net/ipv4/netfilter/ipt_rpfilter.c

View file

7

net/ipv4/route.c

View file