MIPS: TXx9: tx49xx: Move GPIO setup from .mem_setup() to .arch_init()

Browse source

txx9_gpio_init() calls gpiochip_add_data(), which fails with -ENOMEM as
it is called too early in the boot process. This causes all subsequent
GPIO operations to fail silently (before commit 54d77198fd ("gpio:
bail out silently on NULL descriptors") it printed the error message
"gpiod_direction_output_raw: invalid GPIO" on RBTX49[23]7).

Postpone all GPIO setup to .arch_init() time to fix this.

Suggested-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/14237/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

...

This commit is contained in:

Geert Uytterhoeven 2016-09-11 10:48:33 +02:00 • committed by Ralf Baechle

parent 561eca4990

commit 5ac676ade1

4 changed files with 23 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

arch/mips/txx9/generic/setup_tx4927.c

View file

1

arch/mips/txx9/generic/setup_tx4938.c

View file

32

arch/mips/txx9/rbtx4927/setup.c

View file

1

arch/mips/txx9/rbtx4938/setup.c

View file