drm/i915/dsb: Load LUTs using the DSB during vblank

Browse source

Loading LUTs with the DSB outside of vblank doesn't really
work due to the palette anti-collision logic. Apparently the
DSB register writes don't get stalled like CPU mmio writes
do and instead we end up corrupting the LUT entries. Disabling
the anti-collision logic would allow us to successfully load
the LUT outside of vblank, but presumably that risks the LUT
reads from the scanout (temporarily) getting corrupted data
from the LUT instead.

The anti-collision logic isn't active during vblank so that
is when we can successfully load the LUT with the DSB. That is
what we want to do anyway to avoid tearing.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230606191504.18099-13-ville.syrjala@linux.intel.com
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

...

This commit is contained in:

Ville Syrjälä 2023-06-06 22:14:57 +03:00

parent dd1c3eae58

commit 5ae0da3fc7

4 changed files with 32 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

30

drivers/gpu/drm/i915/display/intel_color.c

View file

2

drivers/gpu/drm/i915/display/intel_color.h

View file

4

drivers/gpu/drm/i915/display/intel_crtc.c

View file

3

drivers/gpu/drm/i915/display/intel_display.c

View file