Merge branch 'fixes-for-ocelot-driver-statistics'

Browse source

Vladimir Oltean says:

====================
Fixes for Ocelot driver statistics

This series contains bug fixes for the ocelot drivers (both switchdev
and DSA). Some concern the counters exposed to ethtool -S, and others to
the counters exposed to ifconfig. I'm aware that the changes are fairly
large, but I wanted to prioritize on a proper approach to addressing the
issues rather than a quick hack.

Some of the noticed problems:
- bad register offsets for some counters
- unhandled concurrency leading to corrupted counters
- unhandled 32-bit wraparound of ifconfig counters

The issues on the ocelot switchdev driver were noticed through code
inspection, I do not have the hardware to test.

This patch set necessarily converts ocelot->stats_lock from a mutex to a
spinlock. I know this affects Colin Foster's development with the SPI
controlled VSC7512. I have other changes prepared for net-next that
convert this back into a mutex (along with other changes in this area).
====================

Link: https://lore.kernel.org/r/20220816135352.1431497-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Jakub Kicinski 2022-08-17 21:58:48 -07:00

parent 211987f3ac e780e3193e

commit 5b6a07297b

7 changed files with 1581 additions and 378 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

558

drivers/net/dsa/ocelot/felix_vsc9959.c

View file

553

drivers/net/dsa/ocelot/seville_vsc9953.c

View file

62

drivers/net/ethernet/mscc/ocelot.c

View file

55

drivers/net/ethernet/mscc/ocelot_net.c

View file

468

drivers/net/ethernet/mscc/ocelot_vsc7514.c

View file

84

drivers/net/ethernet/mscc/vsc7514_regs.c

View file

179

include/soc/mscc/ocelot.h

View file