mlxsw: spectrum_ethtool: Remove internal speeds from PTYS register

Browse source

The PTYS register is used to report and configure the port type and
speed. Currently, internal bits in the register are used the same way
other bits are used.

Using the internal bits can cause bad parameter firmware errors. For
example, trying to write to internal bit 25 returns:

EMAD reg access failed (tid=53e2bffa00004310,reg_id=5004(ptys),type=write,status=7(bad parameter))

Remove the internal bits from the PTYS register, so that it is no longer
possible to pass them to firmware.

Signed-off-by: Danielle Ratson <danieller@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Danielle Ratson 2020-08-23 11:06:28 +03:00 • committed by David S. Miller

parent ffff9c9cb4

commit 5bf01b571c

3 changed files with 1 additions and 68 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/mellanox/mlxsw/reg.h

View file

38

drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c

View file

25

drivers/net/ethernet/mellanox/mlxsw/switchx2.c

View file