ixgbe: do not use adapter->num_vfs when setting VFs via module parameter

Browse source

Avoid setting adapter->num_vfs early in the init code path when
using the max_vfs module parameter by passing it to ixgbe_enable_sriov()
as a function parameter.

This fixes an issue where if we failed to allocate vfinfo in
__ixgbe_enable_sriov() the driver will crash with NULL pointer in
ixgbe_disable_sriov() when attempting to free the vfinfo struct based
on adapter->num_vfs. Also it cleans up the assignment of adapter->num_vfs
since now it will only be set in __ixgbe_enable_sriov() and cleared in
ixgbe_disable_sriov().

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

...

This commit is contained in:

Emil Tantilov 2017-01-20 14:11:56 -08:00 • committed by Jeff Kirsher

parent da614d042a

commit 5c11f00dda

3 changed files with 28 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

View file

50

drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

View file

2

drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h

View file