rtl8712: pwrctrl_priv: Replace semaphore lock with mutex

Browse source

The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it
should be written as one. Semaphores are going away in the future.
_enter_pwrlock was using down_interruptible(), so the lock could be broken
by sending a signal. This could be a bug, because nothing checks the return
code here. Hence, using mutex_lock instead of the interruptible version.
Removing the now unused _enter_pwrlock and _down_sema.

Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Binoy Jayan 2016-08-22 10:09:42 +05:30 • committed by Greg Kroah-Hartman

parent b2bcdadcf9

commit 5c2ba8b85e

4 changed files with 17 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/staging/rtl8712/osdep_service.h

View file

10

drivers/staging/rtl8712/rtl8712_cmd.c

View file

22

drivers/staging/rtl8712/rtl871x_pwrctrl.c

View file

7

drivers/staging/rtl8712/rtl871x_pwrctrl.h

View file