netfilter: conntrack: get rid of tuple in helper definitions

Browse source

Leftover from the days when the kernel did automatic assignment of helpers
based on a pre-registered / well-known-port.

This helper autoassign was removed from the kernel, so all we really
need are the l3 and l4 protocol numbers.

In the broadcast helper, the only remaining consumer of the port number is
removed.  AFAICS its not needed: The expectation is populated from the
control connection reply tuple, so the src port is the original directions
destination (snmp/161 for example).

LLM complained about silent l3num (u16) -> nfproto (u8) truncation, so
add a netlink policy validation to reject large NFPROTO values upfront.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Florian Westphal <fw@strlen.de>

...

This commit is contained in:

Florian Westphal 2026-06-29 14:58:22 +02:00

parent 26fb502773

commit 5de6c8ad0b

6 changed files with 29 additions and 35 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

include/net/netfilter/nf_conntrack_helper.h

View file

2

net/netfilter/nf_conntrack_broadcast.c

View file

22

net/netfilter/nf_conntrack_helper.c

View file

6

net/netfilter/nf_conntrack_ovs.c

View file

21

net/netfilter/nfnetlink_cthelper.c

View file

4

net/sched/act_ct.c

View file