inet_diag: fix possible overflow in inet_diag_dump_one_icsk()

Browse source

[ Upstream commit c8e2c80d7e ]

inet_diag_dump_one_icsk() allocates too small skb.

Add inet_sk_attr_size() helper right before inet_sk_diag_fill()
so that it can be updated if/when new attributes are added.

iproute2/ss currently does not use this dump_one() interface,
this might explain nobody noticed this problem yet.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Eric Dumazet 2015-03-13 09:49:59 -07:00 • committed by Greg Kroah-Hartman

parent 03d7e82103

commit 5e1c79561c

1 changed files with 15 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

18

net/ipv4/inet_diag.c

View file