fs: simplify misleading code to remove ambiguity regarding ihold()/iput()

Browse source

Because 'inode' is being initialised before checking if 'dentry' is negative
it looks like an extra iput() on 'inode' may happen since the ihold() is
done only if the dentry is *not* negative.  In reality this doesn't happen
because d_is_negative() is never true if ->d_inode is NULL.  This patch only
makes the code easier to understand, as I was initially mislead by it.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
Link: https://lore.kernel.org/r/20230928152341.303-1-lhenriques@suse.de
Signed-off-by: Christian Brauner <brauner@kernel.org>

...

This commit is contained in:

Luís Henriques 2023-09-28 16:23:41 +01:00 • committed by Christian Brauner

parent 85fadf89e5

commit 6036c5f131

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

1 changed files with 1 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

fs/namei.c

View file