KVM: x86: Add helpers to query individual CR0/CR4 bits

Browse source

Add helpers to check if a specific CR0/CR4 bit is set to avoid a plethora
of implicit casts from the "unsigned long" return of kvm_read_cr*_bits(),
and to make each caller's intent more obvious.

Defer converting helpers that do truly ugly casts from "unsigned long" to
"int", e.g. is_pse(), to a future commit so that their conversion is more
isolated.

Opportunistically drop the superfluous pcid_enabled from kvm_set_cr3();
the local variable is used only once, immediately after its declaration.

Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
Link: https://lore.kernel.org/r/20230322045824.22970-2-binbin.wu@linux.intel.com
[sean: move "obvious" conversions to this commit, massage changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>

...

This commit is contained in:

Binbin Wu 2023-03-22 12:58:21 +08:00 • committed by Sean Christopherson

parent 0c928ff26b

commit 607475cfa0

8 changed files with 35 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

arch/x86/kvm/cpuid.c

View file

16

arch/x86/kvm/kvm_cache_regs.h

View file

2

arch/x86/kvm/mmu.h

View file

4

arch/x86/kvm/pmu.c

View file

2

arch/x86/kvm/vmx/nested.c

View file

2

arch/x86/kvm/vmx/vmx.c

View file

22

arch/x86/kvm/x86.c

View file

4

arch/x86/kvm/x86.h

View file