drm/xe: Use symbol namespace for kunit tests

Browse source

Instead of simply using EXPORT_SYMBOL() to export the functions needed
in xe.ko to be be called across modules, use EXPORT_SYMBOL_IF_KUNIT()
which will export the symbol under the EXPORTED_FOR_KUNIT_TESTING
namespace.

This avoids accidentally "leaking" these functions and letting them be
called from outside the kunit tests. If these functiosn are accidentally
called from another module, they receive a modpost error like below:

	ERROR: modpost: module XXXXXXX uses symbol
	xe_ccs_migrate_kunit from namespace EXPORTED_FOR_KUNIT_TESTING,
	but does not import it.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Link: https://lore.kernel.org/r/20230401085151.1786204-4-lucas.demarchi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

...

This commit is contained in:

Lucas De Marchi 2023-04-01 01:51:47 -07:00 • committed by Rodrigo Vivi

parent af049be5a3

commit 60d5c6abc2

6 changed files with 10 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/gpu/drm/xe/tests/xe_bo.c

View file

1

drivers/gpu/drm/xe/tests/xe_bo_test.c

View file

3

drivers/gpu/drm/xe/tests/xe_dma_buf.c

View file

1

drivers/gpu/drm/xe/tests/xe_dma_buf_test.c

View file

3

drivers/gpu/drm/xe/tests/xe_migrate.c

View file

1

drivers/gpu/drm/xe/tests/xe_migrate_test.c

View file