staging/lustre/ptlrpc: Protect request buffer changing

Browse source

*_enlarge_reqbuf class of functions can change request body location
for a request that's already in replay list, as such a parallel
traverser of the list (after_reply -> ptlrpc_free_committed) might
access freed and scrambled memory causing assertion.

Since all such users only can get to this request under imp_lock, take
imp_lock to protect against them in *_enlarge_reqbuf

Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/10074
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3333
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Oleg Drokin 2014-06-22 21:32:06 -04:00 • committed by Greg Kroah-Hartman

parent 3eeb821eff

commit 61d7258bf1

3 changed files with 52 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

29

drivers/staging/lustre/lustre/ptlrpc/gss/sec_gss.c

View file

11

drivers/staging/lustre/lustre/ptlrpc/sec_null.c

View file

12

drivers/staging/lustre/lustre/ptlrpc/sec_plain.c

View file