ALSA: usb-audio: Roll back quirk control caches on write errors

Browse source

Several mixer quirk callbacks cache the requested
control value in kcontrol->private_value before
issuing a single vendor or class write.

Their paired get and resume paths consume that cache
directly, so a failed write currently leaves software
state changed even though the update did not succeed.
That can make later reads report a value the device
never accepted and can replay the stale cache on resume.

Restore the previous cached value on failure in
the Audigy2NX LED, Emu0204 channel switch,
Xonar U1 output switch, Native Instruments controls,
FTU effect program switch, and Sound Blaster E1 input source switch.

Fixes: 9cf3689bfe ("ALSA: usb-audio: Add audigy2nx resume support")
Fixes: 5f503ee9e2 ("ALSA: usb-audio: Add Emu0204 channel switch resume support")
Fixes: 2bfb14c3b8 ("ALSA: usb-audio: Add Xonar U1 resume support")
Fixes: da6d276957 ("ALSA: usb-audio: Add resume support for Native Instruments controls")
Fixes: 0b4e9cfcef ("ALSA: usb-audio: Add resume support for FTU controls")
Fixes: 388fdb8f88 ("ALSA: usb-audio: Support changing input on Sound Blaster E1")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260429-alsa-usb-quirks-cache-rollback-v1-1-01b35c688b80@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

...

This commit is contained in:

Cássio Gabriel 2026-04-29 10:20:01 -03:00 • committed by Takashi Iwai

parent 6e934725ec

commit 6380957fa2

1 changed files with 37 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

45

sound/usb/mixer_quirks.c

View file