net/mlx4_en: fix tx_dropped bug

Browse source

1) mlx4_en_xmit() can increment priv->stats.tx_dropped, but this variable
is overwritten in mlx4_en_DUMP_ETH_STATS().

2) This increment was not SMP safe, as a port might have many TX queues.

Add a per TX ring tx_dropped to fix these issues.

This is u32 as mlx4_en_DUMP_ETH_STATS() will add a 32bit field.

So lets avoid bugs with SNMP agents having to cope with partial
overwraps. (One of these agents being bond_fold_stats())

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Willem de Bruijn <willemb@google.com>
Cc: Eugenia Emantayev <eugenia@mellanox.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Eric Dumazet 2016-05-25 09:50:36 -07:00 • committed by David S. Miller

parent bed187b540

commit 63a664b7e9

4 changed files with 9 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

View file

4

drivers/net/ethernet/mellanox/mlx4/en_port.c

View file

8

drivers/net/ethernet/mellanox/mlx4/en_tx.c

View file

1

drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

View file