cxgb4: Use struct_group() for memcpy() region

Browse source

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memcpy(), memmove(), and memset(), avoid
intentionally writing across neighboring fields.

Use struct_group() in struct fw_eth_tx_pkt_vm_wr around members ethmacdst,
ethmacsrc, ethtype, and vlantci, so they can be referenced together. This
will allow memcpy() and sizeof() to more easily reason about sizes,
improve readability, and avoid future warnings about writing beyond the
end of ethmacdst.

"pahole" shows no size nor member offset changes to struct
fw_eth_tx_pkt_vm_wr. "objdump -d" shows no object code changes.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Kees Cook 2021-11-18 10:42:35 -08:00 • committed by David S. Miller

parent 88181f1d34

commit 641d3ef00c

3 changed files with 13 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/net/ethernet/chelsio/cxgb4/sge.c

View file

10

drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h

View file

7

drivers/net/ethernet/chelsio/cxgb4vf/sge.c

View file