media: coda: fix memory corruption in case more than 32 instances are opened

Browse source

The ffz() return value is undefined if the instance mask does not
contain any zeros. If it returned 32, the following set_bit would
corrupt the debugfs_root pointer.
Switch to IDA for context index allocation. This also removes the
artificial 32 instance limit for all except CodaDx6.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

...

This commit is contained in:

Philipp Zabel 2018-11-06 05:40:54 -05:00 • committed by Mauro Carvalho Chehab

parent c45fbdf24c

commit 649cfc2bdf

2 changed files with 12 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

26

drivers/media/platform/coda/coda-common.c

View file

3

drivers/media/platform/coda/coda.h

View file