pNFS/flexfiles: Fix a deadlock on LAYOUTGET

Browse source

We encountered a deadlock where the SEQUENCE that accompanied the
LAYOUTGET triggered a session drain, while ff_layout_alloc_lseg
triggered a GETDEVICEINFO.  The GETDEVICEINFO hung waiting for the
session drain, while the LAYOUTGET held the slot waiting for
alloc_lseg to finish.
  Avoid this by moving the call to nfs4_find_get_deviceid out of
ff_layout_alloc_lseg and into nfs4_ff_layout_prepare_ds.

Signed-off-by: Fred Isaman <fred.isaman@gmail.com>
[dros@primarydata.com: pNFS/flexfiles: fix races in ff_layout_mirror_valid]
Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

...

This commit is contained in:

Fred Isaman 2016-09-30 14:37:41 -04:00 • committed by Trond Myklebust

parent 2f065ddb64

commit 65990d1afb

3 changed files with 43 additions and 46 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

37

fs/nfs/flexfilelayout/flexfilelayout.c

View file

2

fs/nfs/flexfilelayout/flexfilelayout.h

View file

50

fs/nfs/flexfilelayout/flexfilelayoutdev.c

View file