drm/vmwgfx: Restart command buffers after errors

Browse source

Previously we skipped the command buffer and added an extra fence to
avoid hangs due to skipped fence commands.
Now we instead restart the command buffer after the failing command,
if there are any commands left.
In addition we print out some information about the failing command
and its location in the command buffer.

Testing Done: ran glxgears using mesa modified to send the NOP_ERROR
command before each 10th clear and verified that we detected the device
error properly and that there were no other device errors caused by
incorrectly ordered command buffers. Also ran the piglit "quick" test
suite which generates a couple of device errors and verified that
they were handled as intended.

Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>

...

This commit is contained in:

Thomas Hellstrom 2017-08-24 08:06:29 +02:00 • committed by Sinclair Yeh

parent ef369904aa

commit 65b97a2bec

3 changed files with 206 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

183

drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c

View file

2

drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

View file

48

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

View file