IPoIB: Fix memory leak in the neigh table deletion flow

Browse source

If the neighbours hash table is empty when unloading the module, then
ipoib_flush_neighs(), the cleanup routine, isn't called and the
memory used for the hash table itself leaked.

To fix this, ipoib_flush_neighs() is allways called, and another
completion object is added to signal when the table is freed.

Once invoked, ipoib_flush_neighs() flushes all the neighbours (if
there are any), calls the the hash table RCU free routine, which now
signals completion of the deletion process, and waits for the last
neighbour to be freed.

Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

...

This commit is contained in:

Shlomo Pongratz 2012-08-29 15:14:33 +00:00 • committed by Roland Dreier

parent fea7a08acb

commit 66172c0993

2 changed files with 21 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/infiniband/ulp/ipoib/ipoib.h

View file

23

drivers/infiniband/ulp/ipoib/ipoib_main.c

View file