drm/i915: Mark FIFO underrun disabled earlier

Browse source

At least on some platforms (tested on ctg) the way
vgacon does screen blanking seems to flag constant
FIFO underruns, which means we have to be prepared
for them while the driver is loading. Currently
there is a time window between drm_crtc_init() and
intel_sanitize_fifo_underrun_reporting() during
which FIFO underrun reporting is in fact marked as
enabled. Thus we may end up mistakenly detecting
these bogus underruns during driver init.

Close the race by marking FIFO underrun reporting
as disabled prior to even registering the crtc.
intel_sanitize_fifo_underrun_reporting()/etc. will
re-enable it later if needed.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230125185234.21599-2-ville.syrjala@linux.intel.com
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

...

This commit is contained in:

Ville Syrjälä 2023-01-25 20:52:30 +02:00

parent 5eba742605

commit 66560f3305

4 changed files with 32 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/display/intel_crtc.c

View file

20

drivers/gpu/drm/i915/display/intel_fifo_underrun.c

View file

3

drivers/gpu/drm/i915/display/intel_fifo_underrun.h

View file

24

drivers/gpu/drm/i915/display/intel_modeset_setup.c

View file