drm/amd/display: Do cursor programming with rest of pipe

Browse source

Cursors are always programmed independently of updates on other
planes. When atomic commits program cursor and surface updates
together the cursor update might be locked out by the surface
update and not take effect.

To combat this program cursor and surface updates together via
dc_update_planes_and_stream to ensure they can be applied
atomically.

When cursor updates come on their own use the old method
to program the cursor as dc_update_planes_and_stream isn't
handling this case correctly (yet), leading to a flickering
screen.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2186
Reviewed-by: Agustin Gutierrez <agustin.gutierrez@amd.com>
Acked-by: Wayne Lin <wayne.lin@amd.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Harry Wentland 2024-03-15 13:02:00 -04:00 • committed by Alex Deucher

parent 3a99045c56

commit 66eba12a54

6 changed files with 105 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

79

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

View file

4

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c

View file

3

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h

View file

5

drivers/gpu/drm/amd/display/dc/core/dc.c

View file

14

drivers/gpu/drm/amd/display/dc/core/dc_stream.c

View file

12

drivers/gpu/drm/amd/display/dc/dc_stream.h

View file