drm/i915: Fix DP link training pattern mask

Browse source

An LTTPR can be trained with training pattern 4 even if the DPCD
revision is < 1.4, but drm_dp_training_pattern_mask() would change
pattern 4 to pattern 3 on those DPCD revisions.

Since intel_dp_training_pattern() makes already sure that the proper
training pattern is used, all that needs to be masked out is the
scrambling disable flag, which is or'd to the mask later based on the
training pattern.

v2:
- Use a helper instead of open-coding the masking. (Ville)

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201007170917.1764556-2-imre.deak@intel.com

...

This commit is contained in:

Imre Deak 2020-10-07 20:09:12 +03:00

parent 3bcacad3d7

commit 6777a855d6

4 changed files with 13 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/display/intel_ddi.c

View file

10

drivers/gpu/drm/i915/display/intel_dp.c

View file

2

drivers/gpu/drm/i915/display/intel_dp_link_training.c

View file

6

drivers/gpu/drm/i915/display/intel_dp_link_training.h

View file