ucc_geth: Fix IRQ freeing code in ucc_geth_open()

Browse source

open() routine calls stop() in case of errors, the function will try
to free the requested IRQ. But we don't know if it was actually
requested, so the code might issue bogus free_irq(0, dev) call.

Fix this by rearranging the code so that now request_irq() is the last
call in the open() routine, and move free_irq() into the close().

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Anton Vorontsov 2008-12-18 08:23:29 +00:00 • committed by David S. Miller

parent 1762a29ae5

commit 67c2fb8ff0

1 changed files with 8 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

drivers/net/ucc_geth.c

View file