drm/amdkfd: Add initial VI support for KQ

Browse source

This patch starts to add support for the VI APU in the KQ (kernel queue)
module.

Because most (more than 90%) of the KQ code is shared among AMD's APUs, we
chose a design that performs most/all the code in the shared KQ file
(kfd_kernel_queue.c). If there is H/W specific code to be executed,
than it is written in an asic-specific extension function for that H/W.

That asic-specific extension function is called from the shared function at the
appropriate time. This requires that for every asic-specific extension function
that is implemented in a specific ASIC, there will be an equivalent
implementation in ALL ASICs, even if those implementations are just stubs.

That way we achieve:

- Maintainability: by having one copy of most of the code, we only need to
  fix bugs at one locations

- Readability: very clear what is the shared code and what is done per ASIC

- Extensibility: very easy to add new H/W specific files/functions

Signed-off-by: Ben Goz <ben.goz@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Ben Goz 2014-12-02 16:38:57 +02:00 • committed by Oded Gabbay

parent 443fbd5f11

commit 6898f0a568

5 changed files with 127 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/amd/amdkfd/Makefile

View file

21

drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c

View file

7

drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.h

View file

44

drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_cik.c

View file

56

drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c

View file