Merge branch 'bpf: refine retval for bpf_get_task_stack helper'

Browse source

Dave Marchevsky says:

====================

Similarly to the bpf_get_stack helper, bpf_get_task_stack's return value
can be more tightly bound by the verifier - it's the number of bytes
written to a user-supplied buffer, or a negative error value. Currently
the verifier believes bpf_task_get_stack's retval bounds to be unknown,
requiring extraneous bounds checking to remedy.

Adding it to do_refine_retval_range fixes the issue, as evidenced by
new selftests which fail to load if retval bounds are not refined.

v2: Addressed comment nit in patch 3
====================

Signed-off-by: Alexei Starovoitov <ast@kernel.org>

...

This commit is contained in:

Alexei Starovoitov 2021-04-19 18:23:34 -07:00

parent 137733d08f c77cec5c20

commit 69443c4730

4 changed files with 72 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

kernel/bpf/verifier.c

View file

1

tools/testing/selftests/bpf/prog_tests/bpf_iter.c

View file

27

tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c

View file

43

tools/testing/selftests/bpf/verifier/bpf_get_stack.c

View file